Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ruff.toml format in README #10393

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Use ruff.toml format in README #10393

merged 1 commit into from
Mar 13, 2024

Conversation

charliermarsh
Copy link
Member

Summary

See feedback in #4725 (comment).

In the docs, we use a tabbed interface for express ruff.toml vs. pyproject.toml. Here, it might be clearer to default to ruff.toml, since it's more obviously not pyproject.toml. But either way, this PR attempts to clarify that there's a difference.

@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label Mar 13, 2024
README.md Outdated
The remaining configuration options can be provided through a catch-all `--config` argument:

```shell
ruff check path/to/code/ --config "lint.per-file-ignores = {'some_file.py' = ['F841']}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love path/to/code/ here it seems like a bad example as a corollary for file discovery options.

I know it's copied from above but maybe a good time to improve

Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charliermarsh charliermarsh enabled auto-merge (squash) March 13, 2024 18:42
@charliermarsh charliermarsh merged commit e9d3f71 into main Mar 13, 2024
16 checks passed
@charliermarsh charliermarsh deleted the charlie/c branch March 13, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants